Communities

Writing
Writing
Codidact Meta
Codidact Meta
The Great Outdoors
The Great Outdoors
Photography & Video
Photography & Video
Scientific Speculation
Scientific Speculation
Cooking
Cooking
Electrical Engineering
Electrical Engineering
Judaism
Judaism
Languages & Linguistics
Languages & Linguistics
Software Development
Software Development
Mathematics
Mathematics
Christianity
Christianity
Code Golf
Code Golf
Music
Music
Physics
Physics
Linux Systems
Linux Systems
Power Users
Power Users
Tabletop RPGs
Tabletop RPGs
Community Proposals
Community Proposals
tag:snake search within a tag
answers:0 unanswered questions
user:xxxx search by author id
score:0.5 posts with 0.5+ score
"snake oil" exact phrase
votes:4 posts with 4+ votes
created:<1w created < 1 week ago
post_type:xxxx type of post
Search help
Notifications
Mark all as read See all your notifications »
Q&A

Welcome to Codidact Meta!

Codidact Meta is the meta-discussion site for the Codidact community network and the Codidact software. Whether you have bug reports or feature requests, support questions or rule discussions that touch the whole network – this is the site for you.

Comments on Edit button is still "Suggest Edit"

Post

Edit button is still "Suggest Edit"

+8
−0

I recently got the ability to directly edit posts. However, the button to edit the posts still is still labeled as "Suggest Edit" instead of simply "Edit".

toolbar

This is purely a visual bug; I am still able to directly edit posts.

History
Why does this post require attention from curators or moderators?
You might want to add some details to your flag.
Why should this post be closed?

1 comment thread

General comments (6 comments)
General comments
Monica Cellio‭ wrote over 3 years ago · edited over 3 years ago

Is this still happening? (Trying to rule out caching.) Also, congratulations!

Moshi‭ wrote over 3 years ago

@MonicaCellio Thanks :) It's still happening. I also hard refreshed, so I don't think it's a cache issue with my browser.

Monica Cellio‭ wrote over 3 years ago

Thanks for checking. The other possibility was that we were caching it, though I'd expect us to refresh that at the same time we check/update abilities. So looks like a bug. Thanks for the report.

sau226‭ wrote over 3 years ago

The check that decides what text to render in that location was checking for an ability with internal name 'edit_post', while the actual ability is called 'edit_posts' (note the 's').

Fix submitted, should be merged in the near future and all will be well with the deploy after merge

FoggyFinder‭ wrote over 3 years ago

Monica Cellio‭ I thought the fix is already in. Current version is poining to the 9fdbbe185c40c61eb6175111423e75348e67f45e commit while fix is in 56a080f6a2a5ee599de493ce300cf5afa35d781b commit which is before. Or is it some kind of mess with commits history?

Monica Cellio‭ wrote over 3 years ago

Sorry FoggyFinder‭ - I thought we were still waiting for deploy, but that's because I apparently shouldn't try to read commit logs before caffeine. :-) Moshi says it's fixed, so I've updated the tag.