Communities

Writing
Writing
Codidact Meta
Codidact Meta
The Great Outdoors
The Great Outdoors
Photography & Video
Photography & Video
Scientific Speculation
Scientific Speculation
Cooking
Cooking
Electrical Engineering
Electrical Engineering
Judaism
Judaism
Languages & Linguistics
Languages & Linguistics
Software Development
Software Development
Mathematics
Mathematics
Christianity
Christianity
Code Golf
Code Golf
Music
Music
Physics
Physics
Linux Systems
Linux Systems
Power Users
Power Users
Tabletop RPGs
Tabletop RPGs
Community Proposals
Community Proposals
tag:snake search within a tag
answers:0 unanswered questions
user:xxxx search by author id
score:0.5 posts with 0.5+ score
"snake oil" exact phrase
votes:4 posts with 4+ votes
created:<1w created < 1 week ago
post_type:xxxx type of post
Search help
Notifications
Mark all as read See all your notifications »
Q&A

Welcome to Codidact Meta!

Codidact Meta is the meta-discussion site for the Codidact community network and the Codidact software. Whether you have bug reports or feature requests, support questions or rule discussions that touch the whole network – this is the site for you.

Comments on Possible bug with how to earn the Edit Posts ability

Post

Possible bug with how to earn the Edit Posts ability

+1
−0

Is there a discrepancy between the description on the Edit Posts Ability page and the way that assignment of the ability is calculated?

Edit Posts Ability page showing progress bar at 100%

The image shows the Edit Posts Ability page for me on the Code Golf Codidact community (reached by following the "Abilities" link in the "Earned Abilities" section of my Profile page).

Note that the progress bar shows 100%, but I do not have the ability.

The description says:

To earn this ability, you need to have at least a 95% approval rate for your suggested edits, with a hard minimum of 30 approved suggested edits (these numbers may vary from site to site).

From the Activity tab of my Profile it appears that I have 55 suggested edits marked as "helpful" and none rejected, which seems consistent with the progress bar showing 100%.

Does this indicate a bug somewhere? Presumably if the target had been set higher for this particular community then my progress bar would not be showing 100%.

History
Why does this post require attention from curators or moderators?
You might want to add some details to your flag.
Why should this post be closed?

1 comment thread

Looks like a bug. I can confirm that the threshold is not set differently on Code Golf. Thanks for t... (11 comments)
Looks like a bug. I can confirm that the threshold is not set differently on Code Golf. Thanks for t...
Monica Cellio‭ wrote 6 months ago

Looks like a bug. I can confirm that the threshold is not set differently on Code Golf. Thanks for the report, and sorry for the delayed empowerment.

trichoplax‭ wrote 6 months ago

I'm happy waiting longer to be able to edit - it's not something I need often so I won't be making too much work for edit reviewers. Just wanted to raise the bug so it isn't forgotten.

luap42‭ wrote 6 months ago

I recalced your abilities manually, so you should now have the ability to edit posts directly, but this does indicate an issue where the recalc script doesn't run or doesn't work correctly, so we'll have to look into it.

trichoplax‭ wrote 6 months ago

Thank you - that worked and I have the ability now.

trichoplax‭ wrote 6 months ago

Possibly related bug (probably too rare and unimportant to make a new Meta post, unlike you'd like me to):

Now that I have the Edit Posts ability, viewing my own suggested edit that was made before I had the ability shows the message "You can't approve or reject suggested edits because you haven't yet earned the Edit Posts ability".

I'm not sure if this is because the suggested edit predates my gaining the ability, or if this is because it's my own suggested edit. I would guess that neither of these reasons is a good reason to prevent someone approving a suggested edit, so maybe there's a bug somewhere.

This is mostly out of interest, as it's just one edit and it's not important.

Monica Cellio‭ wrote 6 months ago

It looks like it's because it's your suggestion. I just checked the code, and two conditions must apply: (you have the edit ability or it's your post), and it's not your own suggested edit. I guess it would make sense to drop that last part? If you have the ability now, you'd be able to make that edit directly, so it makes sense that you can approve your own edit. On the other hand, an astute user could game the system to rack up a bunch of free approved edits, which could feed into another ability someday. On the third hand... is that rare case something to guard against?

trichoplax‭ wrote 6 months ago

For now, I agree that the restriction on approving your own suggested edits is redundant. As you say, I could simply make the edit directly rather than via a suggestion now that I have the ability, so the restriction is an inconvenience rather than a real protection.

If at some point we introduce a third layer beyond "not able to edit" and "able to edit", then that would probably involve carefully rethinking everything anyway, so this restriction could be added back in then.

trichoplax‭ wrote 6 months ago

Just checked and I was wrong about the restriction being just an inconvenience. Since the Edit button below a post is replaced with "Review suggested edit", there is no way for me to edit that post until the suggested edit is approved.

I'd expect this to be a rare problem, as on most communities where someone has had enough suggested edits approved to get the ability, there will probably be enough reviewers around to approve such left over suggested edits. Mentioning just as an extra small argument in favour of removing the restriction.

Monica Cellio‭ wrote 5 months ago

The bug with blocking your previous suggested edits is now fixed. The main issue of why the ability wasn't recalculated remains.

trichoplax‭ wrote 5 months ago

Thank you! I've now been able to approve my old suggested edit.

Monica Cellio‭ wrote 5 months ago

Thanks for confirming the fix in prod. (We tested on the dev server where noisy edits don't get in anyone's way, but I didn't have a convenient test case here.)