Notifications
Sign Up Sign In
Q&A

Welcome to Codidact Meta!

Codidact Meta is the meta-discussion site for the Codidact community network and the Codidact software. Whether you have bug reports or feature requests, support questions or rule discussions that touch the whole network – this is the site for you.

Should [status-completed] be used before the changes are live?

+6
−0

As of the time of writing, this request has the [status-completed] tag despite the change not being live yet. It is completely developed, sure, but since it is not yet deployed, should the request be marked completed?

Why should this post be closed?

0 comments

2 answers

+6
−1

A tag on the community meta should reflect the status as experienced by the community. A change in tag should communicate a change in experience. This allows users to provide feedback (it's working, it's not) rather than being unsure whether or not the new functionality is live because it might still be living in deployment limbo.

Comparing timestamps on deployment and update is non-intuitive. We should follow the principle of least astonishment and let status-complete mean complete from the view of the end user.

9 comments

"Meta's tags are mainly used as a way for the site builders and administrators to keep track of what is completed or not" your words. A PR seems "job done" as far as a site builder is concerned. ‭pnuts‭ 24 days ago

@pnuts, yes, Sigma's words. Sigma even says explicitly here in the answer: "...and let status-complete mean complete from the view of the end user". What Sigma wrote here is not in contradiction to what has been written in the answer you linked to. "keep track of what is completed or not" does not necessarily imply a different meaning of "completeness" than what Sigma wrote here. ‭elgonzo‭ 24 days ago

I can live with a little delay in the interest of making things easier for the developers, -1. While not perfect, Status-Completed when the code has been changed is good enough for me. Otherwise, the developers have to remember to come back to find outstanding "Code-updated" (or whatever) and change them to "Status-Implemented". I would rather keep it simple for the volunteers doing the work. ‭Olin Lathrop‭ 24 days ago

@elgonzo I suspect anything other than a space immediately after 'username' (immediately following@) does not ping. (And two or more word usernames might need to have the spaces removed.) ‭pnuts‭ 24 days ago

@Olin Lathrop are you fine with "a little delay" of a couple days? ‭Moshi‭ 24 days ago

Show 4 more comments
+3
−6

[status-completed] gets added once the code has been written, reviewed, and merged - i.e. is ready to deploy. Once [status-completed] has been added to a post, you can assume it'll be deployed in the next build - you can tell whether that's happened or not yet by comparing the timestamp on the answer with the timestamp of the build hash in the footer.

8 comments

Sorry, but I disagree. status-completed implies that users will actually see the change, and it is is confusing in the interim between the "completion" and the "deploy" times. ‭Moshi‭ 25 days ago

@ArtOfCode I think that's fine for the dev team tracking their own progress in Trello. But for user-facing progress indicators--which these tags are--saying an item is complete before it's deployed is like announcing to a packed restaurant that desert is ready to be served, but by the way we won't actually bring it out to you for another few days. ‭ShowMeBillyJo‭ 25 days ago

I see the other post has now been updated with status-planned. I think that's a good approach. We can move it to status-completed after deploy. ‭Monica Cellio‭ 25 days ago

@MonicaCellio - this is the post under discussion; it still has [status-completed]. (There's another, similar, request that's tagged [status-planned] because the PR hasn't been merged yet.) ‭Mithical‭ 25 days ago

I'd prefer the tag be premature (provided only very slightly) rather than be overlooked altogether. For me "will be live the next time a deploy happens" is good enough clarification for a short period. I imagine coupling the tag with the PR action makes it less likely it will be forgotten. ‭pnuts‭ 25 days ago

Show 3 more comments

Sign up to answer this question »